Require Pimple 3.0 instead of whole of Silex #35
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dont know if you want to change the namespace, as it currently contains "Silex" in its name. |
Merged
|
👍 |
|
@henrikbjorn Good idea but i see some problems with this PR
My fault, did not read carefull enough (tests) |
|
@dominikzogg the 2.x versions are confused and contain a file that class_aliases Pimple to Container, and for that reason it will not work with the extension. So 3.0 is the correct version |
|
👍 |
|
@igorw would be cool, if you would merge this |
|
+1 on merging this |
|
i use my fork, i hope you will join, your PR is already within master, v1 is for silex ~1.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.