Added an advanced example, returning a different filename. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $response = $this->get('igorw_file_serve.response_factory') | ||
| ->create( $filename = $real_path, | ||
| $contentType = 'application/octet-stream', | ||
| $options = $file_options, |
There was a problem hiding this comment.
why assigning new variables here ?
There was a problem hiding this comment.
To clarify the example code. If you like you can write it in a line, but for me it's a bit confusing.
Now that including the arguments names have the same intention.
There was a problem hiding this comment.
the issue is not about using several lines but about creating the $filename, $contentType and $options variables (btw, I'm not even sure it is valid)
|
However, this worked fine. |
|
Merged, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added an advanced example, where a different filename is returned. This worked for me and it's not documented.