$response object passed as service argument instead of resolveDispositionHeaderFilename() argument

[inmarelibero]

$request object is now passed through services.xml instead of passing it optionally in the controller as option.
What do you think?

[igorw]

I wanted to avoid scoping everything to request, because it's messy. But it's probably a good idea for convenience.

[igorw]

Can you add a type hint for Request?

[inmarelibero]

yes, i put a use Symfony\Component\HttpFoundation\Request; in the top, like use Symfony\Component\HttpFoundation\Response;

[inmarelibero]

yes, I found a bit complicate for users to be forced to pass the $request object in the create()function just to avoid the problem in IE, Safari and Konqueror. And that it should be transparent for the user.

[igorw]

No, the default behaviour is to send the invalid header which works in all browsers. You need to pass the request to get the valid one.

[igorw]

Can you adjust the README?

[inmarelibero]

just to make it clear:

• now users are not required to pass the $request object in the controller as option to the create() function
• I update the readme writing that support for browsers that are not RFC compliant (IE, safari and konqueror) has been provided

right?

[igorw]

I've updated it myself.

Ist gemerged ;-)

[inmarelibero]

ok cool. many thanks for your work!