-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Because 9000 #15
Because 9000 #15
Conversation
alcohol
commented
Nov 3, 2014
👍 |
1 similar comment
👍 |
👍 |
This PR has been open for 11 days, this is why Open Source has a bad reputation. @igorw you're hurting developers. |
Can confirm what @davedevelopment is saying. I am losing sleep over this not being merged ._. |
sorry needs more gifs |
When xdebug reports how many times a line is ran to PHPUnit, PHPUnit could average the 9000 runs of those few lines with the total code coverage reports. This would make it much easier to get to 100% coverage. You could even get more than 100% code coverage! Quality projects could then aim for about 500% code coverage. Yolo would then measurably be the highest quality PHP project (it already probably is the highest quality, but that's subjective). This single change could more than double the quality of virtually every PHP project overnight! I might submit a pull request to PHPUnit to make it do this. Should it be configurable, in case some people still want the old way of reporting? |
I kind of feel like you're just not interested in playing along @igorw |
Almost as if you don't want to see me succeed @igorw |
@philsturgeon I think there needs to be a PSR on this. |
Must agree with @TazeTSchnitzel. @philsturgeon we need a PR for a PSR on how to make a PSR for this PR. PSR-9000, How to Yolo correctly. |
@ckdarby Insufficient quantities of GIF in your comment. |
@TazeTSchnitzel That is what you think... |
@ckdarby Also lacking GIFs. |
@TazeTSchnitzel Github tried to stop the gif'ing from me but I've since fixed it |
@ckdarby How dare you slander the name of the great Octocat with such lies! |
@TazeTSchnitzel I'll say whatever I please against the mighty Octocat god. Don't make me put you back in the box where you belong. |
@igorw fears if this is merged |
Nonsense @ckdarby, it would be more like this! |
@davedevelopment A fork would be damaging to the yolo ecosystem. We can't let this happen. |
@TazeTSchnitzel you're absolutely right, please take me back |
This PR is simply unacceptable in its current form. The level of JIFs is much to low. It's almost as if someone had tried to download the internet but stopped after one floppy disk. |
|