Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Because 9000 #15

Closed
wants to merge 1 commit into from
Closed

Because 9000 #15

wants to merge 1 commit into from

Conversation

alcohol
Copy link

@alcohol alcohol commented Nov 3, 2014

TRUTHS

@davedevelopment
Copy link
Contributor

👍

1 similar comment
@simensen
Copy link

simensen commented Nov 5, 2014

👍

@hikari-no-yume
Copy link
Collaborator

@ckdarby
Copy link

ckdarby commented Nov 8, 2014

👍

@alcohol
Copy link
Author

alcohol commented Nov 8, 2014

Needs more gifs I was told.

gif

@alcohol
Copy link
Author

alcohol commented Nov 8, 2014

gif

@alcohol
Copy link
Author

alcohol commented Nov 14, 2014

Plz merge

merge

@davedevelopment
Copy link
Contributor

This PR has been open for 11 days, this is why Open Source has a bad reputation. @igorw you're hurting developers.

@ckdarby
Copy link

ckdarby commented Nov 14, 2014

Can confirm what @davedevelopment is saying. I am losing sleep over this not being merged ._.

@hikari-no-yume
Copy link
Collaborator

@igorw please, like @ckdarby I am getting no sleep and it's *slowly chipping* away at ymy     sanityHELP me

@alcohol
Copy link
Author

alcohol commented Nov 14, 2014

merge or...

@hikari-no-yume
Copy link
Collaborator

@futurevision
Copy link

image

@spdionis
Copy link

So many issues, so little time…
sad

@igorw
Copy link
Owner

igorw commented Nov 15, 2014

sorry needs more gifs

@dave1010
Copy link

When xdebug reports how many times a line is ran to PHPUnit, PHPUnit could average the 9000 runs of those few lines with the total code coverage reports.

This would make it much easier to get to 100% coverage. You could even get more than 100% code coverage! Quality projects could then aim for about 500% code coverage. Yolo would then measurably be the highest quality PHP project (it already probably is the highest quality, but that's subjective).

This single change could more than double the quality of virtually every PHP project overnight! I might submit a pull request to PHPUnit to make it do this. Should it be configurable, in case some people still want the old way of reporting?

test

@alcohol
Copy link
Author

alcohol commented Nov 15, 2014

I kind of feel like you're just not interested in playing along @igorw

nothanks

@alcohol
Copy link
Author

alcohol commented Nov 15, 2014

Almost as if you don't want to see me succeed @igorw

almost

@futurevision
Copy link

Igor is doing this to you alcohol:

fail8-gif

@philsturgeon
Copy link

pleeeeease

@hikari-no-yume
Copy link
Collaborator

@philsturgeon I think there needs to be a PSR on this.

@ckdarby
Copy link

ckdarby commented Nov 15, 2014

Must agree with @TazeTSchnitzel. @philsturgeon we need a PR for a PSR on how to make a PSR for this PR.

PSR-9000, How to Yolo correctly.

@hikari-no-yume
Copy link
Collaborator

@ckdarby Insufficient quantities of GIF in your comment.

@ckdarby
Copy link

ckdarby commented Nov 15, 2014

@TazeTSchnitzel That is what you think...

image

@hikari-no-yume
Copy link
Collaborator

@ckdarby Also lacking GIFs.

I am disappoint.

@ckdarby
Copy link

ckdarby commented Nov 15, 2014

@TazeTSchnitzel Github tried to stop the gif'ing from me but I've since fixed it

image

@hikari-no-yume
Copy link
Collaborator

@ckdarby How dare you slander the name of the great Octocat with such lies!

@ckdarby
Copy link

ckdarby commented Nov 15, 2014

@TazeTSchnitzel I'll say whatever I please against the mighty Octocat god. Don't make me put you back in the box where you belong.

image

@duxet
Copy link

duxet commented Nov 16, 2014

more

@ckdarby
Copy link

ckdarby commented Nov 16, 2014

@igorw fears if this is merged

@alcohol
Copy link
Author

alcohol commented Nov 16, 2014

Nonsense @ckdarby, it would be more like this!
blooming

@alcohol
Copy link
Author

alcohol commented Nov 19, 2014

notrelevant

@alcohol
Copy link
Author

alcohol commented Nov 19, 2014

mergealready

@ckdarby
Copy link

ckdarby commented Nov 19, 2014

@alcohol This is you attempting to get @igorw to accept this PR

...not even close...

@davedevelopment
Copy link
Contributor

I think I've seen enough here, it's time to fork yolo - who's coming with me?!

gif

@hikari-no-yume
Copy link
Collaborator

@davedevelopment A fork would be damaging to the yolo ecosystem. We can't let this happen.

@davedevelopment
Copy link
Contributor

@TazeTSchnitzel you're absolutely right, please take me back

@igorw
Copy link
Owner

igorw commented Nov 20, 2014

This PR is simply unacceptable in its current form. The level of JIFs is much to low. It's almost as if someone had tried to download the internet but stopped after one floppy disk.

@hikari-no-yume
Copy link
Collaborator

JIF

@alcohol alcohol closed this Dec 4, 2014
@davedevelopment
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet