Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use *3d functions rather than rgl.* functions #619

Merged
merged 2 commits into from
Jan 4, 2023
Merged

Conversation

dmurdoch
Copy link
Contributor

@dmurdoch dmurdoch commented Jan 1, 2023

rgl will be deprecating a number of rgl.* functions in an upcoming release. (See https://github.com/dmurdoch/rgl/blob/deprecated/vignettes/deprecation.Rmd for a discussion of the issues.) This PR does two things:

  • It substitutes equivalent *3d calls for the rgl.* calls.
  • It removes workaround code that may have been needed with the rgl.* calls, but doesn't appear to be needed now.

@ntamas
Copy link
Member

ntamas commented Jan 2, 2023

LGTM but I'm not familar with rgl so I'll leave it to @krlmlr to decide whether this can be merged.

@ntamas ntamas requested a review from krlmlr January 2, 2023 08:57
Copy link
Contributor

@krlmlr krlmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good.

@ntamas ntamas merged commit 5c3c358 into igraph:dev Jan 4, 2023
github-actions bot pushed a commit that referenced this pull request Jan 4, 2023
Use *3d functions rather than rgl.* functions [Triggered by 5c3c358]
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants