Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: export .from() etc. with behavior similar to dplyr::across() #1436

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

maelle
Copy link
Contributor

@maelle maelle commented Jul 18, 2024

Fix #1435

A drawback: the tree "nei" functions are actually only for index sequences but I let them output the same message. Is that bad?

Also, the help link does not work for me but it looks correct, maybe just a problem with my IDE version? I'd be grateful if you could try it on your side.

@maelle maelle requested a review from krlmlr July 18, 2024 12:22
Copy link
Contributor

aviator-app bot commented Jul 18, 2024

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This pull request is currently open (not queued).

How to merge

To merge this PR, comment /aviator merge or add the mergequeue label.


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

Copy link
Contributor

@krlmlr krlmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, will try locally.

These days, I'd use generated code instead of clever code like this. One drawback is that environment(.from) is not the igraph environment; to achieve this, we'd need even cleverer code.

@krlmlr
Copy link
Contributor

krlmlr commented Jul 18, 2024

Would you like to add examples of correct usage, or a link to the help topic where they are described? Perhaps even merge with that existing help topic (if it, well, exists)?

@maelle
Copy link
Contributor Author

maelle commented Jul 19, 2024

These days, I'd use generated code instead of clever code like this. One drawback is that environment(.from) is not the igraph environment; to achieve this, we'd need even cleverer code.

Do we need to tackle this here?

@maelle
Copy link
Contributor Author

maelle commented Jul 19, 2024

@maelle
Copy link
Contributor Author

maelle commented Jul 19, 2024

Would you like to add examples of correct usage, or a link to the help topic where they are described? Perhaps even merge with that existing help topic (if it, well, exists)?

Painstakingly added the links. 😁

@maelle maelle requested a review from krlmlr July 19, 2024 15:23
@krlmlr krlmlr changed the title feat: export .from() etc. with behavior similar to dplyr::across() feat: export .from() etc. with behavior similar to dplyr::across() Jul 19, 2024
Copy link
Contributor

@krlmlr krlmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove the keywords internal at some point, shouldn't be a blocker for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export .from etc. with behavior similar to dplyr::across()
2 participants