-
-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: export .from()
etc. with behavior similar to dplyr::across()
#1436
base: main
Are you sure you want to change the base?
Conversation
Current Aviator status
This pull request is currently open (not queued). How to mergeTo merge this PR, comment
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, will try locally.
These days, I'd use generated code instead of clever code like this. One drawback is that environment(.from)
is not the igraph environment; to achieve this, we'd need even cleverer code.
Would you like to add examples of correct usage, or a link to the help topic where they are described? Perhaps even merge with that existing help topic (if it, well, exists)? |
Do we need to tackle this here? |
Painstakingly added the links. 😁 |
.from()
etc. with behavior similar to dplyr::across().from()
etc. with behavior similar to dplyr::across()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove the keywords internal
at some point, shouldn't be a blocker for now.
Fix #1435
A drawback: the tree "nei" functions are actually only for index sequences but I let them output the same message. Is that bad?
Also, the help link does not work for me but it looks correct, maybe just a problem with my IDE version? I'd be grateful if you could try it on your side.