-
-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Factor support #193
Factor support #193
Conversation
In order to avoid conversion of factors attribute elements are initialised prior to assignment if the attribute does not exist or if the assignment is overwriting all elements within that attribute
FWIW, the failed build has nothing to do with this PR... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The codes look ok to me.
Are these changes present in the R igraph package? In my case, set_vertex_attr() and vertex_attr()<- both still convert factors to integers |
@mathlandry , no this code is not yet merged. This is a Pull Request with new proposed code that should still be integrated in the main codebase. After it will be merged, you can install it using |
Thank you for your contribution. This has conflicts now and needs to be redone. The original issue #34 has a reprex and points to this PR. |
Current Aviator status
This PR was closed without merging. If you still want to merge this PR, re-open it.
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
Fixes #34
In order to avoid conversion of factors attribute elements are
initialised prior to assignment if the attribute does not exist or if
the assignment is overwriting all elements within that attribute