Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up as_adj_list if igraph_opt("return.vs.es") is false #196

Closed
wants to merge 1 commit into from

Conversation

cfhammill
Copy link
Contributor

Also updates the docs to point out that this option exists. Not a fully satisfying solution to #194, but provides a simple work around.

Update documentation to point out that this option exists.
@gaborcsardi
Copy link
Contributor

Thanks! I assume that you checked that after addind create_vs, it is still fast. :)

@cfhammill
Copy link
Contributor Author

cfhammill commented May 25, 2017

It is fast if you set igraph_options(return.vs.es = FALSE). I don't know if create_vs could be sped up. It looks like the first major time waster is V(graph), this takes 9ms, so for a 40000 node graph, it should take 360 odd seconds. After that, adding the graph reference 40000 times takes about 6 seconds. So if create_vs could take a vertex list corresponding to the graph or cache the vertex list it would be a pretty substantial speed up.

@vtraag
Copy link
Member

vtraag commented Mar 5, 2021

@cfhammill , I guess that PR #197 renders this PR obsolete and should be preferred over this one?

@ntamas
Copy link
Member

ntamas commented Sep 24, 2021

This PR seems to be superseded by #197 so I'm closing this.

@ntamas ntamas closed this Sep 24, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants