Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't require 'em-synchrony/amqp' #178

Open
hghdo opened this issue Feb 3, 2014 · 11 comments
Open

Can't require 'em-synchrony/amqp' #178

hghdo opened this issue Feb 3, 2014 · 11 comments

Comments

@hghdo
Copy link

hghdo commented Feb 3, 2014

Hi all
I can't require 'em-synchrony/amqp'
It complains:

em-synchrony/amqp.rb:189:in `<module:AMQP>': undefined method `client=' for AMQP:Module (NoMethodError)

I have amqp v1.2.1 installed.

@igrigorik
Copy link
Owner

It's possible that amqp library has been updated and API has changed. Have you tried freezing AMQP gem with an earlier version number?

@myobie
Copy link

myobie commented May 21, 2014

I am seeing this as well with 1.1.0, 1.2.0, and 1.3.0 of the amqp gem.

@michaelkruglos
Copy link

I cant say definitely, that the versions above 1.0.4 don't work. Are there any plans to support newer versions of amqp gem?

@steventen
Copy link

From amqp's change log: AMQ::Client has been removed since v1.1.0

@dgutov
Copy link
Collaborator

dgutov commented Mar 6, 2015

@igrigorik

  gem 'amqp', '= 1.0.0'

does the trick.

dgutov added a commit to dgutov/em-synchrony that referenced this issue Mar 6, 2015
@igrigorik
Copy link
Owner

@dgutov that pull conflates amqp and ActiveRecord changes. Can you make a separate commit+pull for AMQP freeze?

dgutov added a commit to dgutov/em-synchrony that referenced this issue Mar 8, 2015
@dgutov
Copy link
Collaborator

dgutov commented Mar 8, 2015

@igrigorik Sure, if you think that's preferable. I can't run the specs without the other change, though.

igrigorik added a commit that referenced this issue Mar 8, 2015
Nail down amqp version in Gemfile, to work around #178
@jacobhummer
Copy link

@igrigorik any chance you have insight into whether updates are coming to support AMQP gem > 1.0.4? Greatly appreciated if so.

@igrigorik
Copy link
Owner

@jacobhummer I've not kept up with the AMQP stuff, not sure.

@jacobhummer
Copy link

Thank you @igrigorik ! Definitely understandable. Hopefully I'll be able to have a go at it.

@boutil
Copy link

boutil commented Jul 6, 2016

I think that just removing the line ::AMQP.client = ::EM::Synchrony::AMQP::session might be enoug to make it work with newer amqp gems. I've just run the tests on Debian unstable wich contains amqp 1.6, and they passed fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants