Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch order for exception logs #265

Merged
merged 1 commit into from Dec 6, 2021
Merged

Switch order for exception logs #265

merged 1 commit into from Dec 6, 2021

Conversation

gauntface
Copy link
Collaborator

When running the crawler locally I ran into some issues and the output was shrouded by the API response, heading the useful output of the exception.

This change lows the request response, the headers and finally the exception details.

This is more helpful for run time debugging but may be less helpful for historical log viewing, so feel free to close if you've found this ordering to be helpful.

Copy link
Owner

@igrigorik igrigorik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gauntface gauntface merged commit 85dff83 into igrigorik:master Dec 6, 2021
@gauntface gauntface deleted the logs branch December 6, 2021 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants