Add mutexes to client examples to avoid race conditions

igrigorik · Jan 13, 2021 · 7dade60 · 7dade60
1 parent 8ec79e8
commit 7dade60
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 5 deletions.
diff --git a/example/client.rb b/example/client.rb
@@ -42,10 +42,13 @@
 stream = conn.new_stream
 log = Logger.new(stream.id)
 
+conn_mutex = Mutex.new # Synchronize writing to socket
 conn.on(:frame) do |bytes|
-  # puts "Sending bytes: #{bytes.unpack("H*").first}"
-  sock.print bytes
-  sock.flush
+  conn_mutex.synchronize { # Make sure that only one frame is sent at a time
+    # puts "Sending bytes: #{bytes.unpack("H*").first}"
+    sock.print bytes
+    sock.flush
+  }
 end
 conn.on(:frame_sent) do |frame|
   puts "Sent frame: #{frame.inspect}"

diff --git a/example/upgrade_client.rb b/example/upgrade_client.rb
@@ -21,9 +21,12 @@ def request_header_hash
   end
 end
 
+conn_mutex = Mutex.new # Synchronize writing to socket
 conn.on(:frame) do |bytes|
-  sock.print bytes
-  sock.flush
+  conn_mutex.synchronize { # Make sure that only one frame is sent at a time
+    sock.print bytes
+    sock.flush
+  }
 end
 conn.on(:frame_sent) do |frame|
   puts "Sent frame: #{frame.inspect}"