Merge 0b8985a into a9cde3c

lib/http/2/connection.rb

@@ -539,7 +539,7 @@ def connection_settings(frame)
         # Process pending settings we have sent.
         [@pending_settings.shift, :local]
       else
-        connection_error(check) if validate_settings(@remote_role, frame[:payload])
+        connection_error if validate_settings(@remote_role, frame[:payload])
         [frame[:payload], :remote]
       end
 
@@ -593,7 +593,8 @@ def connection_settings(frame)
           # nothing to do
 
         when :settings_max_frame_size
-          # nothing to do
+          # update framer max_frame_size
+          @framer.max_frame_size = v
 
           # else # ignore unknown settings
         end

spec/connection_spec.rb

@@ -49,6 +49,22 @@
 
       expect(@conn.remote_settings[:settings_header_table_size]).to eq 256
     end
+
+    it 'should reflect settings_max_frame_size recevied from peer' do
+      settings = settings_frame
+      settings[:payload] = [[:settings_max_frame_size, 16_385]]
+
+      @conn << f.generate(settings)
+
+      frame = {
+        length: 16_385,
+        type: :data,
+        flags: [:end_stream],
+        stream: 1,
+        payload: 'a' * 16_385,
+      }
+      expect { @conn.send(frame) }.not_to raise_error(CompressionError)
+    end
 
     it 'should send SETTINGS ACK when SETTINGS is received' do
       settings = settings_frame