Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor Stream#data to use byteslice #70

Merged
merged 2 commits into from
Oct 31, 2016
Merged

refactor Stream#data to use byteslice #70

merged 2 commits into from
Oct 31, 2016

Conversation

kenichi
Copy link
Collaborator

@kenichi kenichi commented Oct 30, 2016

ran into this issue when pushing a PNG through Stream#data, noticed slice! instead of byteslice

  • add Stream#chunk_data to byteslice payload into max_size, yield each chunk to the block
  • add multibyte test to stream_spec

@kenichi
refactor Stream#data to use byteslice
920b996 
add multibyte test to stream_spec
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 96.933% when pulling 920b996 on kenichi:bytesize into 0ab8173 on igrigorik:master.

@coveralls
Copy link

coveralls commented Oct 30, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 96.933% when pulling ede878b on kenichi:bytesize into 0ab8173 on igrigorik:master.

@igrigorik igrigorik merged commit b1c2637 into igrigorik:master Oct 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kenichi @coveralls @igrigorik