Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix h2spec 4.2. Frame Size #78

Merged
merged 1 commit into from Nov 17, 2016

Conversation

georgeu2000
Copy link
Collaborator

Previous secure server results:

73 tests, 33 passed, 0 skipped, 40 failed

4.2. Frame Size
    × Sends large size frame that exceeds the SETTINGS_MAX_FRAME_SIZE
      - The endpoint MUST send a FRAME_SIZE_ERROR error.
        Expected: GOAWAY frame (ErrorCode: FRAME_SIZE_ERROR)
                  RST_STREAM frame (ErrorCode: FRAME_SIZE_ERROR)
                  Connection close
          Actual: HEADERS frame (Length: 14, Flags: 4)

New secure server results:

73 tests, 34 passed, 0 skipped, 39 failed

4.2. Frame Size
    ✓ Sends large size frame that exceeds the SETTINGS_MAX_FRAME_SIZE

    ✓ Sends large size frame that exceeds the SETTINGS_MAX_FRAME_SIZE
@coveralls
Copy link

coveralls commented Nov 17, 2016

Coverage Status

Coverage increased (+0.001%) to 96.936% when pulling aee2e30 on georgeu2000:h2spec-4-2-frame-size into 99c7590 on igrigorik:master.

@igrigorik igrigorik merged commit c644c9b into igrigorik:master Nov 17, 2016
@igrigorik
Copy link
Owner

👍

@georgeu2000 georgeu2000 deleted the h2spec-4-2-frame-size branch November 17, 2016 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants