Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to rails version 4.2.8 #211

Merged
merged 1 commit into from Jun 1, 2017
Merged

Bump to rails version 4.2.8 #211

merged 1 commit into from Jun 1, 2017

Conversation

zoso10
Copy link
Collaborator

@zoso10 zoso10 commented Jun 1, 2017

again, another mostly unexciting rails version upgrade. the validation messages changed a little so i had to update a spec

again, another mostly unexciting rails version upgrade.
@zoso10 zoso10 requested a review from igrigorik June 1, 2017 17:02
@@ -40,6 +40,7 @@ group :test, :development do
gem 'simplecov', :require => false
gem "codeclimate-test-reporter", "~> 1.0.0"
gem "capybara"
gem "launchy"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is new requirement for 4.2.8?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i added that so we could use save_and_open_page from capybara for debugging. it's not mission critical so I can remove that if you want :)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha, ok. Nah, that's fine.

@igrigorik igrigorik merged commit 1754a9b into master Jun 1, 2017
@zoso10 zoso10 deleted the te-rails-4.2.8 branch June 2, 2017 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants