Move time function strings/consts to PMEM #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asctime has the months of the year and day of the week as a set of constant strings. Move them to progmem to save 3*(7+12) = 57 bytes. mktime has a couple array of 12 ints, move to PMEM, save 96 bytes. strptime has 12 ints (duplicated from mktime!), move to PMEM, save 48 bytes.
|
This PR looks good, subject to common comments given in previous MR. |
|
Closing in lieu of #5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is related to esp8266/Arduino#3740 , increasing heap RAM on the ESP8266 by moving library constants into ROM.
asctime has the months of the year and day of the week as a set of
constant strings. Move them to progmem to save 3*(7+12) = 57 bytes.
mktime has a couple array of 12 ints, move to PMEM, save 96 bytes.
strptime has 12 ints (duplicated from mktime!), move to PMEM, save 48 bytes.