Skip to content

Commit

Permalink
dpif-netlink: Allow offloading of flows with dl_type 0x1234.
Browse files Browse the repository at this point in the history
'dpif_probe_feature()' always has DPIF_FP_PROBE flag set. Other probing
code uses dpif_execute() with DPIF_OP_EXECUTE, hence never calls
parse_flow_put().
Thus, this 'if' statement is wrong and should be removed as it only
forbids offloading of the real legitimate flows with dl_type 0x1234.
Dummy flows never reach this code.

CC: Paul Blakey <paulb@mellanox.com>
Fixes: 8b668ee ("dpif-netlink: Use netdev flow put api to insert a flow")
Reported-by: Eli Britstein <elibr@mellanox.com>
Acked-by: Roi Dayan <roid@mellanox.com>
Signed-off-by: Ilya Maximets <i.maximets@samsung.com>
  • Loading branch information
igsilya committed Jul 31, 2019
1 parent 0075b7b commit 0218918
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions lib/dpif-netlink.c
Original file line number Diff line number Diff line change
Expand Up @@ -1993,11 +1993,6 @@ parse_flow_put(struct dpif_netlink *dpif, struct dpif_flow_put *put)
return err;
}

/* When we try to install a dummy flow from a probed feature. */
if (match.flow.dl_type == htons(0x1234)) {
return EOPNOTSUPP;
}

in_port = match.flow.in_port.odp_port;
dev = netdev_ports_get(in_port, dpif_class);
if (!dev) {
Expand Down

0 comments on commit 0218918

Please sign in to comment.