Feat/set date range #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
IliaSidash
commented
May 1, 2024
IliaSidash
commented
- CSS styles were added for a new element .tm-tool-bar-date-range, including layout, colors, and typography.
- The JavaScript file iguanachart.js was modified to include a new function periodToDateRange, which converts period strings ('D2', 'M3', etc.) into date ranges.
- Additionally, elements identified by .js-chart-ui-control selector in the code have their data-property and data-value attributes updated to reflect changes in date ranges.
- Moreover, updates on the handlers associated with these controls were also made to reflect the changes.
- Lastly, the minified CSS file was also updated, presumably with the same style changes that were made to the non-minified CSS file.
Removed an unused test script from package.json and deleted npm-shrinkwrap.json to reduce unnecessary clutter in the project. These changes will simplify the project structure and make it easier to maintain.
The minification process has been updated by swapping out the 'node-minify' library with the '@node-minify/core', '@node-minify/cssnano', and '@node-minify/uglify-js' libraries. Adjustments were made in the 'minify.js' and 'package.json' files to accommodate these new libraries.
The new `tm-tool-bar-date-range` class has been added to `_toolbar.css` and `_toolbar.less` to enhance the style of toolbar's date range. The usage of this class is also reflected in the `templates.js` file by replacing sprite icons with textual frequency representations and adding more descriptive title tags for chart control buttons.
Modified the scripts for UI and chart operations to provide better control over the displayed date interval. Added a method to parse date period and interval and update the chart data source accordingly. Extended support to include 'Year to Date' range as well.
The incrementation of the 'dateTo' variable has been added. This adjustment extends the selected date range by one additional day.
Adjusted the hex color values for @Dark-Blue and @md-color-grey-800 in the md_colors.less file. This change updates the color scheme to improve visual consistency and readability in the application.
This commit introduces a conditional check in request date formatting in the charting file, which will only apply the formatting if 'force' variable is not true. Additionally, references to 'intervalMode' settings in chart.js have been removed which were setting it to 'ClosedRay'.
kayvazov
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.