Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pattern slicing of CodableConcepts incorrectly includes display values #78

Closed
ElliotSilver opened this issue Jun 27, 2023 · 3 comments · Fixed by #79
Closed

Pattern slicing of CodableConcepts incorrectly includes display values #78

ElliotSilver opened this issue Jun 27, 2023 · 3 comments · Fixed by #79
Labels
bug agreed to fix as a bug

Comments

@ElliotSilver
Copy link

Section Number

Profiles throughout

Issue

In several profiles, pattern-type slicing discriminators of CodeableConcept (and possibly, Coding and code) elements incorrectly includes the display values in the slice definitions. This means that (a) a code display value is necessary to meet the slice definition, and (b) the specific display value used is necessary to meet the slice definition. This reduces profile usability for environments which may prefer to omit display values for resource size, do not need the clarity that a display value can provide, or which operate in other languages.

Proposed Change

Omit display values for codes used as slicing discriminators (and probably elsewhere in the profile definitions).

Priority:

  • Medium: Significant issue or clarification. Requires discussion, but should not lead to long debate.
@JohnMoehrke
Copy link
Contributor

@ElliotSilver , so are you saying that

* agent[source].type = DCM#110153 "Source Role ID"
* agent[source].who 1..1
* agent[source].network 1..1
* agent[recipient] obeys val-audit-source
* agent[recipient].type = DCM#110152 "Destination Role ID"
* agent[recipient].who 1..1
* agent[recipient].network 1..1

should be

* agent[source].type = DCM#110153
* agent[source].who 1..1
* agent[source].network 1..1
* agent[recipient] obeys val-audit-source
* agent[recipient].type = DCM#110152
* agent[recipient].who 1..1
* agent[recipient].network 1..1

@JohnMoehrke JohnMoehrke added the question Further information is requested label Jul 5, 2023
@ElliotSilver
Copy link
Author

ElliotSilver commented Jul 5, 2023

Correct. See https://chat.fhir.org/#narrow/stream/179252-IG-creation/topic/Best.20practice.20for.20constraining.20CodeableConcepts.20and.20Coding.

Although, I'd leave the display values as comments.

(I don't know if you want to restrict addressing this issue to BALP, or if there is a desire to apply more broadly.)

@JohnMoehrke
Copy link
Contributor

a fsh comment?

  • agent[source].type = DCM#110153 // "Source Role ID"
  • agent[source].who 1..1
  • agent[source].network 1..1
  • agent[recipient] obeys val-audit-source
  • agent[recipient].type = DCM#110152 // "Destination Role ID"
  • agent[recipient].who 1..1
  • agent[recipient].network 1..1

@JohnMoehrke JohnMoehrke added bug agreed to fix as a bug and removed question Further information is requested labels Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug agreed to fix as a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants