Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After downloading shorter track name part of previous one is seen #138

Closed
nrlquaker opened this issue Feb 6, 2018 · 5 comments
Closed
Assignees

Comments

@nrlquaker
Copy link

Python version:
Python 3.6.4

Bandcamp-dl version:
bandcamp-dl 0.0.8-08

Bancamp-dl options:
none

url:
https://nebelung.bandcamp.com/album/palingenesis

options:
none

Describe the issue:

After downloading track with shorter file name part of the previous one is seen in the end.
Here is the example in asciinema.

@Evolution0
Copy link
Collaborator

Yep, this is due to me using sys.stdout.flush()

@Evolution0 Evolution0 reopened this Feb 6, 2018
@Evolution0 Evolution0 self-assigned this Feb 6, 2018
@nrlquaker
Copy link
Author

nrlquaker commented Feb 7, 2018

@Evolution0 It still appears in 0.0.8-09.

@Evolution0
Copy link
Collaborator

This is starting to sound terminal specific, this does not happen in my IDE's terminal after the changes but does in CMD and I'm guessing whichever you use. Suppose I could do this the ugly way and just spam a whole line of blank characters before drawing another.

@Evolution0 Evolution0 reopened this Feb 7, 2018
@Evolution0
Copy link
Collaborator

Did something a bit less ugly than I thought, upgrade and try again.

Should be a pretty foolproof solution, it takes the message to be printed, measures its length, subtracts that from the total width (in characters) of the terminal, then tacks on enough whitespace characters to fill the remainder.

Evolution0 added a commit that referenced this issue Feb 7, 2018
@nrlquaker
Copy link
Author

In 0.0.8-10 its not reproduces. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants