Add support for uvloop #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonafato
reviewed
Oct 18, 2016
| @@ -9,6 +9,7 @@ Release TDB | |||
| - References to objects used by ``henson.Application`` are removed once they | |||
| are no longer needed to allow the memory to be freed up before the next | |||
| message is received. | |||
| - uvloop will be used for the event loop if it's installed. | |||
There was a problem hiding this comment.
It would be nice to link to the uvloop docs here.
uvloop is an alternate event loop for use with asyncio. While it's easy to provide a specific event loop for a Henson application to use when calling `run_forever` directly, there's no easy way to do so when using the `henson run` CLI. Because uvloop is a drop-in replacement, it's easy to add support for it directly into Henson by checking for it at run time. I had originally implemented this by setting the event loop policy at compile time. While that approach feels a tad bit cleaner (easier to remove if we need to stop support uvloop), this approach is much easier to test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uvloop is an alternate event loop for use with asyncio. While it's easy
to provide a specific event loop for a Henson application to use when
calling
run_foreverdirectly, there's no easy way to do so when usingthe
henson runCLI. Because uvloop is a drop-in replacement, it's easyto add support for it directly into Henson by checking for it at run
time.
I had originally implemented this by setting the event loop policy at
compile time. While that approach feels a tad bit cleaner (easier to
remove if we need to stop support uvloop), this approach is much easier
to test.