rename and reorg #16
Merged
rename and reorg #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def fromRootConfig(pipelineName: String, config: Config = ConfigFactory.load())(implicit system: ActorSystem) = { | ||
| val path = "workPipeline.metrics" | ||
| def fromRootConfig(dispatcherName: String, config: Config = ConfigFactory.load())(implicit system: ActorSystem) = { | ||
| val path = "reactiveDispatcher.metrics" |
There was a problem hiding this comment.
maybe have this root config namespace as kanaloa instead of reactiveDispatcher
There was a problem hiding this comment.
will be addressed in the configuration ticket.
|
resolves #8 |
| import com.iheart.workpipeline.akka.patterns.CommonProtocol.{ ShutdownSuccessfully, QueryStatus } | ||
| import com.iheart.workpipeline.collection.FiniteCollection._ | ||
| import Worker.Hold | ||
| import kanaloa.reactive.dispatcher.queue.queue.{ ResultChecker, WorkerRef, QueueRef } |
| import com.iheart.workpipeline.akka.patterns.queue.Queue.{ QueueStatus, WorkEnqueued } | ||
| import com.iheart.workpipeline.akka.patterns.queue.QueueProcessor.{ Shutdown } | ||
| import Queue.{ QueueStatus, WorkEnqueued } | ||
| import QueueProcessor.{ Shutdown } |
There was a problem hiding this comment.
these should already be handled by the import Queue._ and import QueueProcessor._ above? (and the import should probably be the full package name, as mentioned in another comment)
anyway, PR looks ok other than some package naming issues and imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.