a dedicated default config for pulling dispatchers fixes #159 #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling 1574d86 on kailuowang:topic/fix-159 into * on iheartradio:master*. |
| reporter shouldBe empty | ||
| } | ||
|
|
||
| "use specifi default settings" in { |
|
+1 other than my minor comments |
kailuowang
force-pushed
the
topic/fix-159
branch
from
1574d86
to
cbb905a
Compare
|
Changes Unknown when pulling 37ef4a3 on kailuowang:topic/fix-159 into * on iheartradio:master*. |
|
Changes Unknown when pulling 37ef4a3 on kailuowang:topic/fix-159 into * on iheartradio:master*. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PullingDispatcher is quite different from the pushingDispatcher and thus justified to have a dedicated default settings. This also makes shutdownOnAllWorkerDeath default to off. The rationale is stated in the issue #159