Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make statsD metric name consistent with kanaloa fix #136 #167

Merged
merged 2 commits into from
Aug 12, 2016

Conversation

kailuowang
Copy link
Member

No description provided.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling f6422ef on kailuowang:issues/136 into * on iheartradio:master*.

@nsauro
Copy link
Contributor

nsauro commented Aug 12, 2016

I saw this floating around in the dashboard.json:

"aliasColors": {
            "enqueue rejected": "#BF1B00",
            "enqueued": "#7EB26D",
            "rejected": "#E24D42",
            "rejected enqueues": "#E24D42",
            "successful enqueues": "#7EB26D"

Will those cause any issues if their names aren't updated?

Other than that 👍

@kailuowang
Copy link
Member Author

those actually are not in use. but should be removed. I will address those in #154

@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.041% when pulling adddd3b on kailuowang:issues/136 into ba7dd4c on iheartradio:master.

@kailuowang kailuowang merged commit 880d420 into iheartradio:master Aug 12, 2016
@kailuowang kailuowang deleted the issues/136 branch August 12, 2016 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants