Improved stress tests, added automated stress tests #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kailuowang
force-pushed
the
topic/automated-stress
branch
from
bf7802a
to
8932426
Compare
kailuowang
force-pushed
the
topic/automated-stress
branch
from
e20880b
to
bdc0409
Compare
kailuowang
force-pushed
the
topic/automated-stress
branch
4 times, most recently
from
73525e8
to
2adabcb
Compare
kailuowang
force-pushed
the
topic/automated-stress
branch
from
2adabcb
to
2f8f35f
Compare
|
Changes Unknown when pulling 2f8f35f on kailuowang:topic/automated-stress into * on iheartradio:master*. |
| @@ -49,8 +49,8 @@ trait Dispatcher extends Actor with ActorLogging { | |||
|
|
|||
| context watch processor | |||
|
|
|||
| private val autothrottler = settings.autothrottle.foreach { s ⇒ | |||
| context.actorOf(Autothrottler.default(processor, s, metricsCollector), "auto-scaler") | |||
| private val _ = settings.autothrottle.foreach { s ⇒ | |||
There was a problem hiding this comment.
why not just remove this assignment all together?
There was a problem hiding this comment.
this looks more functional? without this the compiler warns on abandoned value.
There was a problem hiding this comment.
I don't have a strong opinion either way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KanaloaSimulations.scalafor detailsKanaloaLocalSimulationfor detail