Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the 'phtread' link flag to fix the issue that the compilation routine could not be linked #81

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

lss1330
Copy link
Contributor

@lss1330 lss1330 commented Apr 23, 2024

image

@ihedvall ihedvall requested a review from Simplxss April 23, 2024 06:01
@Simplxss
Copy link
Collaborator

LINK : fatal error LNK1104: cannot open file 'pthread.lib' [\mdflib\build\msvc-vcpkg-x64\mdflibrary_example\mdflibraryexample.vcxproj]

pthread.lib is only need in gcc.

refer to 53d70fe

if (CMAKE_CXX_COMPILER_ID STREQUAL "GNU" AND CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL 7.3 AND CMAKE_CXX_COMPILER_VERSION VERSION_LESS 9.0 AND NOT MINGW)
  # fix for https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90050
  target_link_libraries(mdflibrary PRIVATE pthread stdc++fs)
endif()

@ihedvall ihedvall merged commit 82e2ffa into ihedvall:main Apr 23, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants