Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Continue movement button should be disabled for castle selection #32

Closed
ihhub opened this issue Sep 8, 2019 · 0 comments
Closed

Continue movement button should be disabled for castle selection #32

ihhub opened this issue Sep 8, 2019 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed improvement New feature, request or improvement ui UI/GUI related stuff

Comments

@ihhub
Copy link
Owner

ihhub commented Sep 8, 2019 •
edited

In original game we have disabled continue movement button when player selects castle:
continue_movement_original

Right now we do not disable the button:
continue_movement_current

We have to have the same logical behaviour.

Start point for this issue is src/heroes/gui/interface_buttons.cpp file.
@ihhub ihhub added improvement New feature, request or improvement help wanted Extra attention is needed good first issue Good for newcomers ui UI/GUI related stuff labels Sep 8, 2019
@ihhub ihhub mentioned this issue Sep 11, 2019
Merged
@ihhub ihhub closed this as completed in fba9350 Sep 11, 2019
taeber pushed a commit to taeber/fheroes2 that referenced this issue Apr 24, 2020
@ihhub @taeber
Show disable continue movement button for castle (ihhub#49)
dba31b5 
close ihhub#32
taeber pushed a commit to taeber/fheroes2 that referenced this issue Apr 24, 2020
@ihhub @taeber
Show disable continue movement button for castle (ihhub#49)
817268d 
close ihhub#32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed improvement New feature, request or improvement ui UI/GUI related stuff
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ihhub