Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spell book is displayed in semi transparent way #34

Closed
ihhub opened this issue Sep 8, 2019 · 1 comment · Fixed by #241
Closed

Spell book is displayed in semi transparent way #34

ihhub opened this issue Sep 8, 2019 · 1 comment · Fixed by #241
Labels
bug Something doesn't work good first issue Good for newcomers help wanted Extra attention is needed ui UI/GUI related stuff

Comments

@ihhub
Copy link
Owner

ihhub commented Sep 8, 2019

In original game spell book is displayed above all other information in hero view window:

spell_book_original

while in current implementation we see that the book is semi transparent which is wrong. We must fix it:

spell_book_current

Partial trick to remove this semi transparency is to click on any of book tabs.
@ihhub ihhub added bug Something doesn't work help wanted Extra attention is needed good first issue Good for newcomers ui UI/GUI related stuff labels Sep 8, 2019
@ihhub
Copy link
Owner Author

ihhub commented Sep 9, 2019

In addition to this it happens on Windows with SDL 1.2.

@ihhub ihhub added the SDL 1 label Sep 9, 2019
andrey-starodubtsev added a commit to andrey-starodubtsev/fheroes2 that referenced this issue Nov 21, 2019
@andrey-starodubtsev
Fix transparency for Spellbook
8b36610 
Spellbook is shown in semi-transparent way on Windows build using SDL1.

This fixes ihhub#34.
@andrey-starodubtsev andrey-starodubtsev mentioned this issue Nov 21, 2019
Merged
ihhub pushed a commit that referenced this issue Nov 22, 2019
@andrey-starodubtsev @ihhub
Fix transparency for Spellbook (#241)
dfa683d 
Spellbook is shown in semi-transparent way on Windows build using SDL1.

This fixes #34.
taeber pushed a commit to taeber/fheroes2 that referenced this issue Apr 24, 2020
@andrey-starodubtsev @taeber
Fix transparency for Spellbook (ihhub#241)
473f372 
Spellbook is shown in semi-transparent way on Windows build using SDL1.

This fixes ihhub#34.
taeber pushed a commit to taeber/fheroes2 that referenced this issue Apr 24, 2020
@andrey-starodubtsev @taeber
Fix transparency for Spellbook (ihhub#241)
ed19319 
Spellbook is shown in semi-transparent way on Windows build using SDL1.

This fixes ihhub#34.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something doesn't work good first issue Good for newcomers help wanted Extra attention is needed ui UI/GUI related stuff
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix transparency for Spellbook andrey-starodubtsev/fheroes2
1 participant
@ihhub