Polish rendering on Adventure Map

[ihhub]

Preliminary checks

• I've checked that there aren't other open issues on the same topic.

Describe the problem requiring a solution

After merging #5692 we still have multiple tasks to be done in order to polish rendering on Adventure Map:

• standartise object fading animation including heroes
• remove old save formats (before 0.9.16? release)
• do not store image parts but rather image regions and flip flag and use them while rendering
• rendering of monsters over Dragon City (added a TODO comment for it)
• rendering heroes / boats outside map while they are in fog
• overlapping of boats during movement (froth should be rendered under another boat for some cases; perspective of boats)
• path icon should be removed after a hero makes a turn, not before
• some objects like flying ghosts over mines are not rendered if the main tile is below the rendering area

Good to have:

• shadows of heroes must be drawn over other objects (tricky one. The original version does this but it breaks a lot of other places. For now we stick with common logic for all objects)

All issues related to rendering on Adventure Map should be reported here to make them easier to track.

Describe the possible solution

Fix everything.

Additional info

No response

[Branikolog]

An issue with wide tree:


Tree.zip

[ihhub]

Hi @Branikolog , I think it works exactly the same way as in the original game due to object info.

[oleg-derevenetz]

It seems that Mine guards are no longer drawn (map "Skirmish"):

[ihhub]

Oh, no. I will fix it.

[Branikolog]

Hi @Branikolog , I think it works exactly the same way as in the original game due to object info.

Hi, @ihhub !
I suppose you're right. But nevertheless this bug should be fixed. ;)

[Branikolog]

{SOLVED}
AI hero priority rendering bug:

Decisions_Hero bug.zip

Edit:
Fixed by #5787

[Branikolog]

Hi, @ihhub
I've noticed that AI hero sprite is partially visible through mountains while moving.

Horse tail.zip

[Branikolog]

{SOLVED}
One more issue:
Alchemist lab flag appears only when the roof is visible on the screen:

[ihhub]

Hi, @ihhub I've noticed that AI hero sprite is partially visible through mountains while moving.

Are you testing the latest version with my fix for AI heroes? If yes is it the same for player's heroes?

[LeHerosInconnu]

The red AI player's hero is displayed over the top of the Necromancer's castle.

In fheroes2:

Here is the save file (1.0.5 7020):
AI hero over top castle 01.zip

[LeHerosInconnu]

Graphic problem with boat near sirens.

In fheroes2:

2023-06-16.11-16-46.mp4

Here is the save file (1.0.5 7020):
Hero path near sirens 01.zip

[LeHerosInconnu]

The blue player's hero is displayed over the top of the water wheel.

In fheroes2:

Here is the save file (1.0.5 7020):
Hero over water wheel 01.zip

[LeHerosInconnu]

The blue player's hero is displayed over the top of the castle.

In fheroes2:

Here is the save file (1.0.5 7308):
Hero over top castle 02.zip

[LeHerosInconnu]

The shadow of the tree is displayed over the hero Crack Hack.

In fheroes2:

Here is the save file (1.0.5 7308):
Tree shadow 01.zip

[Districh-ru]

The right part of the Abandoned mine is not updated after the capture (bug found by apocalypse on Discord):

Save file: ghostmine_capture_sprit_bug.zip

Edit:
Fixed by #7351

[LeHerosInconnu]

A more recent save file for this.
The horse's head is hidden by a tree.

In fheroes2:

Here is the save file (1.0.8 7767):
Hero sprite cut 1000.zip

[LeHerosInconnu]

Another save file for this.

In fheroes2:

2023-10-08.14-06-26.mp4

Here is the save file (1.0.8 7846):
Before hero crackland 01.zip

[LeHerosInconnu]

There's a priority problem between the ghost animation display, the hero flag sprite, and the hero sprite.

In fheroes2:

2024-02-15.13-30-01.mp4

Here is the save file (1.0.12 8369):
Priorite ghost display 01.zip

[LeHerosInconnu]

Display priority problem between boat and sirens.

In fheroes2:

2024-02-21.14-30-56.mp4

Here is the save file (1.0.12 8369):
Ai sirens graphic glitch 01.zip

[LeHerosInconnu]

Display priority problem between hero and stables.

In fheroes2:

2024-06-01.21-35-18.mp4

Here is the save file (1.1.0 8733):
Display priority stables 01.zip