Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the German translation #7860

Closed
1 task done
erazortt opened this issue Oct 3, 2023 · 2 comments
Closed
1 task done

Fix the German translation #7860

erazortt opened this issue Oct 3, 2023 · 2 comments
Labels
improvement New feature, request or improvement translation Things related to languages and translations
Milestone

Comments

@erazortt
Copy link
Contributor

erazortt commented Oct 3, 2023

Preliminary checks

Describe the problem requiring a solution

I have gone through the whole German translation file comparing every entry with the strings inside my original HEROES2.EXE file. I have not taken the strings from the original version blindly however, since at times your current translation was clearly much better. I chose for each string the "best" representation. "Best" can of corse be subjective, however sometimes, the translation was quite bad, and at times even almost unintelligible. In these cases I took the english version as a guide.

Most notable change besides that is that the player is now consistently addressed by the 2nd-person-plural form. There was a weird mix of this form and the 3rd-person-plural form, which was throwing the player out of the lore atmosphere.
I decided to go with the 2nd-person-plural form since this is typlical in German for anything with a medieval theme and for fairy tales. Corresponding movies are also always translated like that into German (Game of Thrones, Lord of the Rings,...).

PS: this issue supersedes #7848

Describe the possible solution

Use this file to update the existing in the repository: de.zip
Merge the pull request #7865.

Additional info

The changes were based on the most current revision of the file (70a635a)

@erazortt erazortt added the improvement New feature, request or improvement label Oct 3, 2023
@oleg-derevenetz oleg-derevenetz added the translation Things related to languages and translations label Oct 4, 2023
@oleg-derevenetz oleg-derevenetz added this to the 1.0.9 milestone Oct 4, 2023
erazortt added a commit to erazortt/fheroes2 that referenced this issue Oct 4, 2023
@erazortt
Copy link
Contributor Author

erazortt commented Oct 5, 2023

I created a pull request. So the zip file should not be needed anymore.

@ihhub
Copy link
Owner

ihhub commented Oct 6, 2023

I am closing this issue as it is an improvement over the existing translation and we have a list of open PRs for this.

@ihhub ihhub closed this as completed Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement New feature, request or improvement translation Things related to languages and translations
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants