Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort headers in alphabetic order in files #88

Closed
ihhub opened this issue Oct 1, 2019 · 8 comments
Closed

Sort headers in alphabetic order in files #88

ihhub opened this issue Oct 1, 2019 · 8 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@ihhub
Copy link
Owner

ihhub commented Oct 1, 2019 •
edited

It's good to have a standardised code style. A good practice is have sorted list of header inclusion for easier navigation between files. We would like to sort header inclusions for all files within src/fheroes2/objects and src/fheroes2/dialog directories.

Sorting header must be done in this way:

  • C++ headers like <iostream>
  • project headers like "army.h"
@ihhub ihhub added help wanted Extra attention is needed good first issue Good for newcomers Hacktoberfest labels Oct 1, 2019
@ihhub
Copy link
Owner Author

ihhub commented Oct 1, 2019

@RisingGeek would you mind to work on this issue?

@ihhub ihhub mentioned this issue Oct 1, 2019
Closed
@RisingGeek
Copy link

Yes, sure

@RisingGeek would you mind to work on this issue?

Yes, sure

@ihhub
Copy link
Owner Author

ihhub commented Oct 1, 2019

Great! Then everyone is happy :)

@ihhub
Copy link
Owner Author

ihhub commented Oct 1, 2019

uh-oh, someone already created a pull request...
@RisingGeek have you started the work on it? If no you could do the same for src/fheroes2/dialog directory.

@ihhub
Copy link
Owner Author

ihhub commented Oct 1, 2019

I could modify the issue to represent both cases/directories.

@RisingGeek
Copy link

Okay, I will work for src/fheroes2/dialog

@AdityaSamantaroy AdityaSamantaroy mentioned this issue Oct 1, 2019
Merged
@rsathya4802 rsathya4802 mentioned this issue Oct 1, 2019
Merged
ihhub pushed a commit that referenced this issue Oct 2, 2019
@rsathya4802 @ihhub
Sorting Headers in alphabetical order in src/fheroes2/objects (#89)
10eccaa 
relates to #88
@ihhub ihhub changed the title Sort headers in alphabetic order in all files in src/fheroes2/objects Sort headers in alphabetic order in files Oct 2, 2019
@ihhub
Copy link
Owner Author

ihhub commented Oct 2, 2019

hi @RisingGeek , are you still working on this issue?

@RisingGeek
Copy link

No

@ihhub ihhub closed this as completed in b46c651 Oct 2, 2019
taeber pushed a commit to taeber/fheroes2 that referenced this issue Apr 24, 2020
@rsathya4802 @taeber
Sorting Headers in alphabetical order in src/fheroes2/objects (ihhub#89)
68c6655 
relates to ihhub#88
taeber pushed a commit to taeber/fheroes2 that referenced this issue Apr 24, 2020
@AdityaSamantaroy @taeber
Sorted headers in alphabetic order (ihhub#94)
b1f4f38 
close ihhub#88
taeber pushed a commit to taeber/fheroes2 that referenced this issue Apr 24, 2020
@rsathya4802 @taeber
Sorting Headers in alphabetical order in src/fheroes2/objects (ihhub#89)
8678bf4 
relates to ihhub#88
taeber pushed a commit to taeber/fheroes2 that referenced this issue Apr 24, 2020
@AdityaSamantaroy @taeber
Sorted headers in alphabetic order (ihhub#94)
86ef3c7 
close ihhub#88
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ihhub @RisingGeek