Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add multi-display device support #8072

Open
wants to merge 57 commits into
base: master
Choose a base branch
from
Open

Add multi-display device support #8072

wants to merge 57 commits into from

Commits on Nov 22, 2023

  1. Upon file deletion scroll to previous file or 0 if first on the list

    @MaMadDl
    MaMadDl committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    aacae0d View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2023

  1. styling fix

    @MaMadDl
    MaMadDl committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    fddf90f View commit details
    Browse the repository at this point in the history

  2. _displayMonitor Property Decleration 

    Getter And Setter Defenition
Setting File Reader And Writer Updated
    @MaMadDl
    MaMadDl committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    622ccc3 View commit details
    Browse the repository at this point in the history

  3. adding _displayMonitor Property to BaseRenderEngine and Display Class

    @MaMadDl
    MaMadDl committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    086cbcb View commit details
    Browse the repository at this point in the history

  4. passing Display Count to render Engine from Display 

    Changing SDL_CreateWindow to process monitor coordinates
    @MaMadDl
    MaMadDl committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    2c42c9c View commit details
    Browse the repository at this point in the history

  5. - Changing GraphicsSetting Dialog to 6 Button ICN 

    - Adding Display Monitor Button
- Adding Filler Image to fill 6th Empty Space
    @MaMadDl
    MaMadDl committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    b9be3e0 View commit details
    Browse the repository at this point in the history

  6. Setting Display Before Create the Window either from setting or default

    @MaMadDl
    MaMadDl committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    1f49b72 View commit details
    Browse the repository at this point in the history

  7. styling fix

    @MaMadDl
    MaMadDl committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    3651946 View commit details
    Browse the repository at this point in the history

  8. more sudden style fix

    @MaMadDl
    MaMadDl committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    0fcc4ea View commit details
    Browse the repository at this point in the history

  9. More Sudden styles fixes from Visual studio

    @MaMadDl
    MaMadDl committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    64aa1cf View commit details
    Browse the repository at this point in the history

  10. Reordering for the Analyzers 

    [-Wreorder-ctor] and  [-Werror=reorder]
    @MaMadDl
    MaMadDl committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    e121a1d View commit details
    Browse the repository at this point in the history

  11. More Reordering For Analyzers 

    Compiled with C5038 enabled as error
    @MaMadDl
    MaMadDl committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    d88c6fd View commit details
    Browse the repository at this point in the history

  12. Update src/engine/screen.h 

    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
    @MaMadDl @github-actions
    MaMadDl and github-actions[bot] committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    604f0df View commit details
    Browse the repository at this point in the history

  13. Update src/engine/screen.h 

    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
    @MaMadDl @github-actions
    MaMadDl and github-actions[bot] committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    04dc878 View commit details
    Browse the repository at this point in the history

  14. Update screen.h

    @MaMadDl
    MaMadDl committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    20f480e View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2023

  1. Update dialog_graphics_settings.cpp 

    include <SDL_video.h> for analyzer
    @MaMadDl
    MaMadDl committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    53b5b46 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2023

  1. Resolving Some Reviews For PR ihhub#8072

    @MaMadDl
    MaMadDl committed Nov 25, 2023
    Configuration menu
    Copy the full SHA
    2aa5eae View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2023

  1. Adding InterfaceType to Graphic Settings 

    Changing Monitor Selection Icon
Moving SDL related function as function inside Screen.h
    @MaMadDl
    MaMadDl committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    6f62708 View commit details
    Browse the repository at this point in the history

  2. rename _displayMonitor property to _displayId with it's getter and se… 

    …tter methods
    @MaMadDl
    MaMadDl committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    d1b65a2 View commit details
    Browse the repository at this point in the history

  3. remove inplace initilization

    @MaMadDl
    MaMadDl committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    5566d2d View commit details
    Browse the repository at this point in the history

  4. fix to style

    @MaMadDl
    MaMadDl committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    1fc9224 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2023

  1. Limiting Screen Switch Ability to windows only

    @MaMadDl
    MaMadDl committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    a193e3e View commit details
    Browse the repository at this point in the history

  2. Changing Mistaken Variable

    @MaMadDl
    MaMadDl committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    8989928 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2023

  1. Addressing Reviews 

    - Removing _displayId variable and it's methods from Display and Settings Class
- Renaming Monitor variable names to Display
- Adding Safeguard to fallback to first display in absence of selected display
    @MaMadDl
    MaMadDl committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    714d867 View commit details
    Browse the repository at this point in the history

  2. styling fix

    @MaMadDl
    MaMadDl committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    d805b6d View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2023

  1. Fix Safeguard

    @MaMadDl
    MaMadDl committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    adf13d6 View commit details
    Browse the repository at this point in the history

  2. Style Fix

    @MaMadDl
    MaMadDl committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    ff368c5 View commit details
    Browse the repository at this point in the history

  3. Remove settings.h

    @MaMadDl
    MaMadDl committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    52f7a53 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2023

  1. Addressing Reviews

    @MaMadDl
    MaMadDl committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    4444c85 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2023

  1. - Add function to change display in runtime 

    - Add Number to display text
- fix some logic
    @MaMadDl
    MaMadDl committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    c2f1f5e View commit details
    Browse the repository at this point in the history

  2. Changing dialog_graphics_settings to 5 item layout with both good and… 

    … evil interface type
    @MaMadDl
    MaMadDl committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    cec93b1 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2024

  1. Adressing Reviews 

    - fixing Space in 2 file
- Updating Text
    @MaMadDl
    MaMadDl committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    662c474 View commit details
    Browse the repository at this point in the history

  2. Removing display Instantiation

    @MaMadDl
    MaMadDl committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    7f36dd5 View commit details
    Browse the repository at this point in the history

  3. Changing Required Headers Date to 2024

    @MaMadDl
    MaMadDl committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    d19573b View commit details
    Browse the repository at this point in the history

  4. Addressing Reviews 

    - Adding Static to getNumberOfVideoDisplays function
- Reverting C++17 if-initilizer style
    @MaMadDl
    MaMadDl committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    051f5e8 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2024

  1. - Changing displayId name to displayIndex 

    - Changing methods in BaseRenderEngine to virtual
- Adding isAllocated methods
- Adding actual implementation in RenderEngine
- Removing ChangeDisplayEngine
- Altering display changing routine
    @MaMadDl
    MaMadDl committed Jan 14, 2024
    Configuration menu
    Copy the full SHA
    76c9b98 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2024

  1. - Changing Description 

    - Fixing Saving output variable to int
    @MaMadDl
    MaMadDl committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    5865c24 View commit details
    Browse the repository at this point in the history

  2. in Graphics Settings: Changing How Background of 2nd Row is created 

    (using Blit on Original Image)
    @MaMadDl
    MaMadDl committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    b1a9987 View commit details
    Browse the repository at this point in the history

  3. style fix

    @MaMadDl
    MaMadDl committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    0a70c34 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2024

  1. Addressing Reviews

    @MaMadDl
    MaMadDl committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    3ce8998 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2024

  1. Addressing Reviews

    @MaMadDl
    MaMadDl committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    deed982 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2024

  1. Update screen.cpp

    @ihhub
    ihhub committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    d5cbd89 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into pr/8072

    @ihhub
    ihhub committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    6f11a10 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'multiMonitorSupport' of https://github.com/MaMadDl/fher… 

    …oes2 into pr/8072
    @ihhub
    ihhub committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    70fd633 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2024

  1. Fix main menu not generating after the display change

    @MaMadDl
    MaMadDl committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    7ff712c View commit details
    Browse the repository at this point in the history

  2. Checking for supported display

    @MaMadDl
    MaMadDl committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    0287e22 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2024

  1. Fixing error for display index on startup

    @MaMadDl
    MaMadDl committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    c2bc9d7 View commit details
    Browse the repository at this point in the history

  2. remove unused variable

    @MaMadDl
    MaMadDl committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    6c06be6 View commit details
    Browse the repository at this point in the history

  3. Fix lambda to calculate on every function call instead of only once

    @MaMadDl
    MaMadDl committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    3af1d73 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2024

  1. return last available display in case cureent display is out of bound

    @MaMadDl
    MaMadDl committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    e6e8050 View commit details
    Browse the repository at this point in the history

  2. handiling SDL_DISPLAYEVENT in a display is disconnected

    @MaMadDl
    MaMadDl committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    2f8e5ef View commit details
    Browse the repository at this point in the history

  3. fix format

    @MaMadDl
    MaMadDl committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    028e3b4 View commit details
    Browse the repository at this point in the history

  4. fix header

    @MaMadDl
    MaMadDl committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    0bc0b0f View commit details
    Browse the repository at this point in the history

  5. remove settings from localevent source

    @MaMadDl
    MaMadDl committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    c2af17e View commit details
    Browse the repository at this point in the history

  6. add Header asked by IWYU

    @MaMadDl
    MaMadDl committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    89b9900 View commit details
    Browse the repository at this point in the history

  7. fix enum

    @MaMadDl
    MaMadDl committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    593b967 View commit details
    Browse the repository at this point in the history

  8. replacing enum SDL_DISPLAYEVENT_DISCONNECTED with it's value

    @MaMadDl
    MaMadDl committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    222d1ad View commit details
    Browse the repository at this point in the history