-
-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the mechanics of Genie special ability #8411
Conversation
The string that logs Genies ability to insta-kill half of enemy stack should be all caps to empasize extreme nature of creature`s absolute destruction. |
It contains an exclamation mark at the end :) In any case, this PR is intended to fix the logic of the Genie ability. I don't know for sure why is this message displayed in its current form, but I suppose that this can be corrected/improved later separately if there is such a need. |
I am sure @Branikolog is going to fight against changing Genie's special ability chances :) |
Hi @ihhub
But they were not changed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything works nice!
I hope chances for applying halving were left the same as before.
Hi @Branikolog
By the way, this is an ambiguous question :) According to the game manual and in fact it was 10%, but it was shown in unit's properties as 20%. Now it is in fact 10% and is shown as 10%. |
Hello, @oleg-derevenetz
There was a discussion 1+year ago regarding genies ability. Some players complained, that in fheroes2 "halving" occurred too rare, comparing to the original game. After making 150+ fights I came to conclusion, that in the original game the ability triggered in more than 15% attacks. So that's why it was set to 20% in fheroes2. |
@Branikolog the funny thing is that change to 20% was obviously made in wrong way. Currently in the |
@oleg-derevenetz , thank you so much for this update! |
To be honest, I don't remember, whether I've tested triggering chances in fheroes2. I was mainly focused on testing the original game leaving the implementation in fheroes2 to the development/contribution team. I'm a bit busy this week, so I cannot perform deep tests. But I can try to make another set of Genies tests in the OG later to be assured, that 20% is an actual chance for triggering. |
Hi @Branikolog
Currently with this PR the chance of triggering is 10%, and it was 10% before merging of this PR too due to an implementation error. Judging by the fact that no one actually noticed this error, it seems that 10% is fine. I can change it to 20% if you want. |
Fix part of #8409 regarding a bug in the game logic.