Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an ability to edit Rumors for maps #8823

Merged
merged 8 commits into from
Jun 17, 2024
Merged

Add an ability to edit Rumors for maps #8823

merged 8 commits into from
Jun 17, 2024

Conversation

ihhub
Copy link
Owner

@ihhub ihhub commented Jun 12, 2024

close #8714

image

image

@ihhub ihhub added improvement New feature, request or improvement ui UI/GUI related stuff editor Map editor related stuff labels Jun 12, 2024
@ihhub ihhub added this to the 1.1.1 milestone Jun 12, 2024
@ihhub ihhub marked this pull request as draft June 12, 2024 14:28
@ihhub ihhub marked this pull request as ready for review June 12, 2024 14:58
Copy link
Collaborator

@Districh-ru Districh-ru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ihhub, rumors works fine!
I left one optional question/suggestion.

src/fheroes2/editor/editor_rumor_window.cpp Show resolved Hide resolved
Copy link
Collaborator

@zenseii zenseii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @ihhub. I left some suggestions for paraphrasing. Please have a look when it's convenient for you.

src/fheroes2/editor/editor_rumor_window.cpp Outdated Show resolved Hide resolved
src/fheroes2/editor/editor_rumor_window.cpp Outdated Show resolved Hide resolved
src/fheroes2/editor/editor_rumor_window.cpp Outdated Show resolved Hide resolved
@Branikolog
Copy link
Collaborator

Hi, @ihhub
I've found out that after pressing OK or Cancel in the rumor creating dialog there's a short delay, before dialog disappears.
image

I do also believe, that tavern window is not really large to keep long texts. Currently, It seems that I can create really long (is there any restrictions at all?) message, that is going not to fit the tavern window.
image
In this case there's no way to even check, what is hidden after "..."

@ihhub
Copy link
Owner Author

ihhub commented Jun 15, 2024

Hi @Branikolog , I've reduced the sentence limit to 200 characters and also expanded the window:
image

image

@ihhub ihhub requested a review from zenseii June 15, 2024 11:12
@Branikolog
Copy link
Collaborator

Hi, @ihhub !

and also expanded the window:

Making window larger does not fix the problem with text editing and looks not really nice in my opinion.
image

Can we use here a window with larger field to edit rumors? Currently it is impossible to read and edit long messages.
Something similar to map description for instance:
image

The problem with delayed window shutdown is still on.

@ihhub
Copy link
Owner Author

ihhub commented Jun 16, 2024

Hi @Branikolog , I've addressed your comments.

Copy link

sonarcloud bot commented Jun 16, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
24.4% Duplication on New Code (required ≤ 5%)

See analysis details on SonarCloud

@ihhub ihhub merged commit 2f3ba10 into master Jun 17, 2024
20 of 21 checks passed
@ihhub ihhub deleted the editor-rumors branch June 17, 2024 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editor Map editor related stuff improvement New feature, request or improvement ui UI/GUI related stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a UI window to add rumors for map in the Editor
4 participants