-
-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an ability to edit Rumors for maps #8823
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ihhub, rumors works fine!
I left one optional question/suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @ihhub. I left some suggestions for paraphrasing. Please have a look when it's convenient for you.
Hi, @ihhub I do also believe, that tavern window is not really large to keep long texts. Currently, It seems that I can create really long (is there any restrictions at all?) message, that is going not to fit the tavern window. |
Hi @Branikolog , I've reduced the sentence limit to 200 characters and also expanded the window: |
Hi, @ihhub !
Making window larger does not fix the problem with text editing and looks not really nice in my opinion. Can we use here a window with larger field to edit rumors? Currently it is impossible to read and edit long messages. The problem with delayed window shutdown is still on. |
Hi @Branikolog , I've addressed your comments. |
Quality Gate failedFailed conditions |
close #8714