Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge opencl_types.h and cuda_types.cuh files #397

Open
ihhub opened this issue Mar 1, 2019 · 2 comments
Open

Merge opencl_types.h and cuda_types.cuh files #397

ihhub opened this issue Mar 1, 2019 · 2 comments
Labels
good first issue An issue is perfectly suitable for first comers. A very minimal knowledge of the project is required help wanted We need a help improvement Upgrade existing feature
Milestone
1.0

Comments

@ihhub
Copy link
Owner

ihhub commented Mar 1, 2019

We have src/opencl/opencl_types.h and 'src/cuda/cuda_types.cuhfiles. Both of them contain 2 template classes which are almost identical. We want to reduce code duplication for such case. Please create a new file calledsrc/gpu/base_types.h` which would include a common code for these two files.
@ihhub ihhub added improvement Upgrade existing feature help wanted We need a help good first issue An issue is perfectly suitable for first comers. A very minimal knowledge of the project is required labels Mar 1, 2019
@ihhub ihhub added this to the Release milestone Mar 1, 2019
This was referenced Mar 1, 2019
Merged
Closed
@manekenpix
Copy link
Contributor

I'd like to work on this one

@ihhub
Copy link
Owner Author

ihhub commented Nov 10, 2019

Hi @manekenpix , sure!

@manekenpix manekenpix mentioned this issue Nov 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue An issue is perfectly suitable for first comers. A very minimal knowledge of the project is required help wanted We need a help improvement Upgrade existing feature
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
2 participants
@ihhub @manekenpix