Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libjpeg support #45

Closed
ihhub opened this issue Jul 3, 2017 · 8 comments
Closed

libjpeg support #45

ihhub opened this issue Jul 3, 2017 · 8 comments
Assignees
Labels
3rd party Source code which is not a part of the project improvement Upgrade existing feature
Milestone

Comments

@ihhub
Copy link
Owner

ihhub commented Jul 3, 2017

We have libpng support but not libjpeg. Many images are stored in this format and it would be irrational to do not support it.

Correlates with #7

@ihhub ihhub added 3rd party Source code which is not a part of the project improvement Upgrade existing feature labels Jul 3, 2017
@ihhub ihhub added this to the 1.0 milestone Sep 11, 2017
@ngetahun
Copy link

Hi @ihhub, I want to get started with this issue. Is it still up for grabs?

@ihhub
Copy link
Owner Author

ihhub commented Oct 15, 2018

@ngetahun yes, it is still available to take. You can work on it.

@ngetahun
Copy link

@ihhub I saw that you didn't add any unit test for png support. Should I do the same for jpeg?

@ngetahun
Copy link

Also, it would be nice to setup some sort of build system (perhaps cmake) or a configuration system (like GNU's autoconf) to check and resolve dependencies.

@ihhub
Copy link
Owner Author

ihhub commented Oct 19, 2018

Ideally we should add unit tests for jpeg. I didn't add unit tests for png because png is not supported on Windows yet (have a look into #41 ).

If you are intending to add jpeg support for Unix OSes as of now then add unit tests under ifdef condition for non-Windows OSes. Later we could add Windows code support and remove ifdef.

@ihhub
Copy link
Owner Author

ihhub commented Oct 19, 2018

Regarding cmake: you are right we should have it too because we cannot build a whole code without checking the presence of certain libraries like libpng or cuda. Could you please create an issue for this?

@ihhub
Copy link
Owner Author

ihhub commented Oct 19, 2018

I'll create another issue regarding unit tests for libpng as well.

@yannlabou
Copy link
Collaborator

Regarding cmake: you are right we should have it too because we cannot build a whole code without checking the presence of certain libraries like libpng or cuda. Could you please create an issue for this?

Yes. #270

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3rd party Source code which is not a part of the project improvement Upgrade existing feature
Projects
None yet
Development

No branches or pull requests

3 participants