Skip to content

Commit

Permalink
set None as default value for config_node.get_value (#355)
Browse files Browse the repository at this point in the history
  • Loading branch information
rmudambi committed Oct 12, 2023
1 parent 3f72d13 commit 9d9f1c4
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 3 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.rst
@@ -1,6 +1,7 @@
**2.1.0 - 10/12/23**

- Remove explicit support for Python 3.8
- Set default value for ConfigNode::get_value to None

**2.0.1 - 10/04/23**

Expand Down
2 changes: 1 addition & 1 deletion src/vivarium/config_tree.py
Expand Up @@ -143,7 +143,7 @@ def freeze(self):
"""
self._frozen = True

def get_value(self, layer: Optional[str]) -> Any:
def get_value(self, layer: Optional[str] = None) -> Any:
"""Returns the value at the specified layer.
If no layer is specified, the outermost (highest priority) layer
Expand Down
8 changes: 6 additions & 2 deletions tests/config_tree/test_basic_functionality.py
Expand Up @@ -144,16 +144,20 @@ def test_node_get_value_with_source(full_node):

def test_node_get_value_empty(empty_node):
with pytest.raises(ConfigurationKeyError):
empty_node.get_value(layer=None)
empty_node.get_value()

for layer in empty_node._layers:
with pytest.raises(ConfigurationKeyError):
empty_node.get_value(layer=layer)
empty_node.get_value()

assert not empty_node.accessed


def test_node_get_value(full_node):
assert full_node.get_value() == f"test_value_{len(full_node._layers)}"
assert full_node.accessed
full_node._accessed = False

assert full_node.get_value(layer=None) == f"test_value_{len(full_node._layers)}"
assert full_node.accessed
full_node._accessed = False
Expand Down

0 comments on commit 9d9f1c4

Please sign in to comment.