Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add locking for update menus #544

Merged
merged 5 commits into from
Jun 17, 2023
Merged

Add locking for update menus #544

merged 5 commits into from
Jun 17, 2023

Conversation

tim-moody
Copy link
Contributor

No description provided.

@tim-moody
Copy link
Contributor Author

testing on a large install would be welcome
passed smoke test and basic functional test

@holta
Copy link
Member

holta commented Jun 14, 2023

@tim-moody
Copy link
Contributor Author

passed smoke test and simple function with latest changes

@holta
Copy link
Member

holta commented Jun 16, 2023

@neomatrixcode can you possibly help?

This PR is likely superseded by a better one here:

@neomatrixcode
Copy link

sudo iiab-diagnostics results after running the command curl iiab.io/fast.txt | bash -s 544

http://sprunge.us/FMib3p

@holta
Copy link
Member

holta commented Jun 17, 2023

http://sprunge.us/FMib3p?en

Many thanks @neomatrixcode for having tested:

  • LARGE-sized as @tim-moody suggested
  • 169G you installed
  • about 35 Content Packs you installed

Conclusion: all testing helps! But we still don't quite know what conditions bring about the iiab/iiab#3487 and iiab/iiab#3602 issues.

@tim-moody
Copy link
Contributor Author

@neomatrixcode thanks for the big test.

I'm not seeing any errors in the diagnostics. Were any problems noticed? Does the home page look right? Is there a maps link?

@tim-moody
Copy link
Contributor Author

Is there a reason not to merge this PR?

@holta
Copy link
Member

holta commented Jun 17, 2023

Is there a reason not to merge this PR?

Feel free and/or to merge PR #545 including this one.

@tim-moody
Copy link
Contributor Author

Problems not addressed by the PR:

  • Services are either not added (OSM) or only added as EN (kalite)
  • Credits is only recognized as last menu item in EN

@tim-moody tim-moody merged commit c9503ad into iiab:master Jun 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants