Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub host #54

Merged
merged 5 commits into from
Apr 28, 2022
Merged

GitHub host #54

merged 5 commits into from
Apr 28, 2022

Conversation

jvonau
Copy link
Contributor

@jvonau jvonau commented Apr 26, 2022

No description provided.

@holta
Copy link
Member

holta commented Apr 26, 2022

@georgejhunt can you review this PR today please if you have time?

And also its companion here:

cc: @tim-moody

@tim-moody
Copy link

we need to determine if regions.json is still used

@jvonau
Copy link
Contributor Author

jvonau commented Apr 26, 2022

@tim-moody
Copy link

For adm cons I see:
adm_lib get_map_catalog() reads /maplist/assets/regions.json
and this is called only by iiab-update-map3.py
that has two functions:

  1. update the home page menu with an appropriate menu def, which I think we no longer want
  2. update the osm home page to redirect from the test page to an installed map, which now is always viewer

@jvonau
Copy link
Contributor Author

jvonau commented Apr 26, 2022

Should be fine once the regions.json file is corrected, the goal here is to have http://download.iiab.io/content/OSM/vector-tiles/maplist/hidden/assets/ and http://timmoody.com/iiab-files/maps/ replaced with github as the authoritative source for these 3 files.

@holta
Copy link
Member

holta commented Apr 26, 2022

This is great!

(Hopefully @georgejhunt has time to quickly weigh in today.)

@jvonau
Copy link
Contributor Author

jvonau commented Apr 26, 2022

For adm cons I see: adm_lib get_map_catalog() reads /maplist/assets/regions.json and this is called only by iiab-update-map3.py that has two functions:

1. update the home page menu with an appropriate menu def, which I think we no longer want

This works nicely as per chat observations, think that is still wanted

2. update the osm home page to redirect from the test page to an installed map, which now is always viewer

That is not quite true as per observations noted in chat 'installer' is the default until more maps are installed then 'viewer' is used.

@jvonau
Copy link
Contributor Author

jvonau commented Apr 27, 2022

Other mentions of regions.json along with adm_lib.py above.

@tim-moody
Copy link

yes. needs clean up.

@holta
Copy link
Member

holta commented Apr 27, 2022

Lets keep the new file in a new directory

This is a good idea.

Let's also think carefully about the naming of the directory to avoid all confusion in future if possible — as George refers to this IIAB Maps effort over the last 4 months as the "2020" version — in connection with the new OSM data files from late 2020 that we're working with here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants