Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

harmonize_year not passed to harmonization methods by Harmonizer #28

Closed
coroa opened this issue Aug 28, 2020 · 0 comments · Fixed by #27
Closed

harmonize_year not passed to harmonization methods by Harmonizer #28

coroa opened this issue Aug 28, 2020 · 0 comments · Fixed by #27

Comments

@coroa
Copy link
Collaborator

coroa commented Aug 28, 2020

The call at

aneris/aneris/harmonize.py

Line 204 in a517292

model = Harmonizer._methods[method](model, delta)
does not contain the Harmonizer's base_year, so that a '2015' base year is implicitly assumed.
coroa added a commit to coroa/aneris that referenced this issue Aug 28, 2020
@coroa
harmonize: Pass harmonize_year to harmonization methods
3585ec2 
Fixes iiasa#28.
@coroa coroa mentioned this issue Aug 28, 2020
Merged
coroa added a commit to coroa/aneris that referenced this issue Sep 14, 2020
@coroa
harmonize: Pass harmonize_year to harmonization methods
5d88809 
Fixes iiasa#28.
coroa added a commit to coroa/aneris that referenced this issue Sep 15, 2020
@coroa
harmonize: Pass harmonize_year to harmonization methods
fc377ca 
Fixes iiasa#28.
coroa added a commit to coroa/aneris that referenced this issue Sep 15, 2020
@coroa
harmonize: Pass harmonize_year to harmonization methods
b271628 
Fixes iiasa#28.
coroa added a commit to coroa/aneris that referenced this issue Sep 16, 2020
@coroa
harmonize: Pass harmonize_year to harmonization methods
5b580f8 
Fixes iiasa#28.
@coroa coroa closed this as completed in #27 Sep 16, 2020
coroa added a commit that referenced this issue Sep 16, 2020
@coroa
harmonize: Use partial to reduce explicit method list (#27)
71731e2 
* Bring back stickler's flake8 configuration

The flake8 invoked by stickler seems to ignore setup.cfg.

* _io: Use yaml.safe_load

* harmonize: Use partial to reduce explicit method list

* harmonize: Pass harmonize_year to harmonization methods

Fixes #28.

* tests: Update regression tests baseline for actual base_year
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

harmonize: Use partial to reduce explicit method list coroa/aneris
1 participant
@coroa