Clean error message for check_out() and refactor to ..._solution
#73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CircleCI passed with tests using deprecated |
gidden
reviewed
Jul 30, 2018
| """delete the solution (variables and equations) from the sceanario""" | ||
| self.clear_cache() # reset Python data cache | ||
| self._jobj.removeSolution() | ||
| if self.has_solution(): |
There was a problem hiding this comment.
if not self.has_solution():
raise
...
|
Ok, just going to merge, not worth changing at this point. Thanks @danielhuppmann! |
|
hey @danielhuppmann, I forgot to think about the release notes. probably worth adding a note that there is a new |
danielhuppmann
added a commit
to danielhuppmann/ixmp
that referenced
this pull request
Jul 30, 2018
3 tasks
gidden
pushed a commit
that referenced
this pull request
Jul 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the error message when checking out a Scenario with a solution from Java to Python, to get the correct function names:
remove_solution()instead of the underlying Java functionremoveSol().In addition, the PR adds a function
has_solution()and renamesremove_sol()toremove_solution(). The kwarg ofclone()is changed fromkeep_soltokeep_solution, butkeep_solcontinues to work (with a deprecation warning).Closes #71