Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement map() method for model and scenario repositories #34

Merged
merged 4 commits into from
Dec 12, 2023
Merged

Implement map() method for model and scenario repositories #34

merged 4 commits into from
Dec 12, 2023

Conversation

danielhuppmann
Copy link
Member

This PR implements (only) the map() methods from #33.

@danielhuppmann danielhuppmann self-assigned this Dec 11, 2023
@danielhuppmann danielhuppmann marked this pull request as ready for review December 11, 2023 16:27
meksor
meksor requested changes Dec 12, 2023
View reviewed changes
ixmp4/core/model.py Outdated Show resolved Hide resolved
ixmp4/core/scenario.py Outdated Show resolved Hide resolved
@danielhuppmann
Copy link
Member Author

Removed the map() from the facade, added tests for the core

meksor
meksor approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@meksor meksor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@danielhuppmann danielhuppmann merged commit 205ce00 into iiasa:main Dec 12, 2023
4 checks passed
@danielhuppmann danielhuppmann deleted the abstract/map branch December 13, 2023 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meksor meksor meksor approved these changes

Assignees

@danielhuppmann danielhuppmann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danielhuppmann @meksor