-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor the facade API to create/get runs #35
Conversation
Co-authored-by: Fridolin Glatter <83776373+glatterf42@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good to me. One note, though: at the moment, the only place where we test providing the version
parameter to runs.get()
is in test_benchmarks
, so it might seem untested by simply looking at test_run
. It is tested, so things are fine, but the test location is not very intuitive.
Thanks for that observation, I added a test for that in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
As just discussed, this PR changes the API to create/get runs from the (implicit)
to the more pythonic
and a corresponding get
Maybe I'm a bit old-fashioned, but I'd still like to keep the default vs. non-default selection implicit in the
get()
method on the facade-layer.fyi @pmussak @glatterf42