Upload Chunking #42
Merged
Upload Chunking #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PS: I bumped fastapi to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the chunking of bulk uploads and deletes in the api layer. Chunk size can be configured with
settings.default_upload_chunk_sizeorIXMP4_DEFAULT_UPLOAD_CHUNK_SIZE.NOTE: If an upload is interrupted between chunks the operation is not rolled back, so use it with care until the versioning system is in place.
I've also added some middleware to log the request size and process time. Seems like most request bodies are now max. around 1 Megabyte so i will probably set the webserver config to 2M max body size after this change is deployed (current is 50M).
IXMP4 will also now throw a verbose error if the webserver responds with a 413 (Payload too large).