Add needed [dataframe] extra for dask #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downstream in message_ix and ixmp (among others), CI tests using the latest dask version (2024.3.0) are failing because "dask-expr" is missing. This is the new backend for
dask.DataFrames and is required because of ixmp4, which doesn't currently specify any extra for dask, thus missing "dask-expr". This PR introduces the "dataframe" extra for dask, which installs "dask-expr".I also ran
poetry lockin the process, so some minor version updates may be included inpoetry.lock.This additionally threw an error message which was related to pandas' coming Copy-on-Write default behaviour, so I quickly fixed that. However, I should open another issue to keep track of this change in pandas and see how it affects us.
@danielhuppmann @meksor (@pmussak FYI) Since downstream projects depend on this fix, could we please do a release 0.7.3 today already?