Integrate included message_doc contents #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khaeru
added a commit
that referenced
this pull request
Aug 30, 2023
* Attempt to call add_product() from Reporter and use it to obtain quantity GDP|PPP from GDP|MER * Add missing * operator in add_product * Simplify of redundant YAML anchors * Fix warning on redefinition of pint variables and typos when using iamc: for GDP variables * Fix typo in comment in core.py * Fix error in dims of gdp_calibrate * Fix entries in combine assuming default values * Editing of add_product function in core.py * Definitive commit containig fixes. Now GDP vars can be included in .xlsx * Fix failure of test_gea due to int64 * Init parameter MERtoPPP to address test failures * Small edit to make pass **test_ldv** * Init MERtoPPP param in bare.py to avoid failure of test_report_bare_res * Remove format from iamc_variable_names * Shift of *product* computation to obtain GDP-PPP to *general* section * Separate 'billion' units * Delete YAML anchor for GDP and deleted report of var GDP_for_calibration * Removed units applied to gdp_calibrate Co-authored-by: Paul Natsuo Kishimoto <mail@paul.kishimoto.name>
khaeru
added a commit
that referenced
this pull request
Aug 30, 2023
* Attempt to call add_product() from Reporter and use it to obtain quantity GDP|PPP from GDP|MER * Add missing * operator in add_product * Simplify of redundant YAML anchors * Fix warning on redefinition of pint variables and typos when using iamc: for GDP variables * Fix typo in comment in core.py * Fix error in dims of gdp_calibrate * Fix entries in combine assuming default values * Editing of add_product function in core.py * Definitive commit containig fixes. Now GDP vars can be included in .xlsx * Fix failure of test_gea due to int64 * Init parameter MERtoPPP to address test failures * Small edit to make pass **test_ldv** * Init MERtoPPP param in bare.py to avoid failure of test_report_bare_res * Remove format from iamc_variable_names * Shift of *product* computation to obtain GDP-PPP to *general* section * Separate 'billion' units * Delete YAML anchor for GDP and deleted report of var GDP_for_calibration * Removed units applied to gdp_calibrate Co-authored-by: Paul Natsuo Kishimoto <mail@paul.kishimoto.name>
khaeru
added a commit
that referenced
this pull request
Aug 31, 2023
* Attempt to call add_product() from Reporter and use it to obtain quantity GDP|PPP from GDP|MER * Add missing * operator in add_product * Simplify of redundant YAML anchors * Fix warning on redefinition of pint variables and typos when using iamc: for GDP variables * Fix typo in comment in core.py * Fix error in dims of gdp_calibrate * Fix entries in combine assuming default values * Editing of add_product function in core.py * Definitive commit containig fixes. Now GDP vars can be included in .xlsx * Fix failure of test_gea due to int64 * Init parameter MERtoPPP to address test failures * Small edit to make pass **test_ldv** * Init MERtoPPP param in bare.py to avoid failure of test_report_bare_res * Remove format from iamc_variable_names * Shift of *product* computation to obtain GDP-PPP to *general* section * Separate 'billion' units * Delete YAML anchor for GDP and deleted report of var GDP_for_calibration * Removed units applied to gdp_calibrate Co-authored-by: Paul Natsuo Kishimoto <mail@paul.kishimoto.name>
khaeru
force-pushed
the
include/message-doc
branch
from
996d4fc
to
c020cc3
Compare
- Consolidate BibTeX/RIS files at the top level. - Remove conf.py, makefiles from sub-tree. - Adjust path references in sources.
khaeru
force-pushed
the
include/message-doc-tidy
branch
from
8402e9b
to
c59d95f
Compare
glatterf42
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This separate branch includes commits to tidy and integrate the contents from message_doc that are added via #107.
The following was previously listed as a TODO for this PR, but I think it can be postponed to a follow-up:
How to review
PR checklist
Add or expand tests;coverage checks both ✅