Correct dev requirements path in cache key

[rlskoeser]

I noticed the cache key had the wrong filename for the dev requirements.

Although I can't tell if the dev requirements are being used anywhere... should they be?

[digitaldogsbody]

Although I can't tell if the dev requirements are being used anywhere... should they be?

This is because setuptools doesn't support a development requirements construct so we moved them to be separate because they are only needed for development (specifically for linting and running tests), and we didn't want to make them a hard requirement of the library.

[digitaldogsbody]

Some discussion of that here: #53

[glenrobson]

I think this would be good to merge. I think the original dev-requirements.txt is a copy and paste error on my part so would be good to fix. It means the gitHub action will get create a new cache if we update either the setup.py file or the dev requirements file.

[rlskoeser]

This is because setuptools doesn't support a development requirements construct so we moved them to be separate because they are only needed for development (specifically for linting and running tests), and we didn't want to make them a hard requirement of the library.

fwiw, you can use named extras for things like dev/test dependencies in setup (not that you need to necessarily use that here)

example:
https://github.com/Princeton-CDH/parasolr/blob/main/setup.py#L15-L21
https://github.com/Princeton-CDH/parasolr/blob/main/setup.py#L38-L42

and then you can install with pip install -e '.[dev]'

[digitaldogsbody]

fwiw, you can use named extras for things like dev/test dependencies in setup (not that you need to necessarily use that here)

example: https://github.com/Princeton-CDH/parasolr/blob/main/setup.py#L15-L21 https://github.com/Princeton-CDH/parasolr/blob/main/setup.py#L38-L42

and then you can install with pip install -e '.[dev]'

It did cross my mind to see if it could be done like this, but I didn't have time to investigate it fully (my experience with setuptools is a little limited). I've opened #73 so that we can refactor it this way in the future, thanks!

[glenrobson]

Still need to move requirements.dev.txt into setup.py.