Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Range helpers, new skeleton, various fixes #84

Merged
merged 13 commits into from
Nov 11, 2022
Merged

Conversation

digitaldogsbody
Copy link
Member

@digitaldogsbody digitaldogsbody commented Oct 6, 2022

Allows Ranges to be added by reference + adds make_range helper
Allows other item types to have thumbnails (NB: this will make some tests fail until IIIF/presentation-validator#151 is merged, and the skeleton.py file regenerated)

closes #45

@glenrobson
Copy link
Contributor

OK I've updated the schema so you should be able to update skeleton.py

@digitaldogsbody
Copy link
Member Author

Skeleton py is updated - and various fixes have been made and also included in this PR

  • Add an Auto for items to ensure it always exists when required (e.g was causing validation errors when trying to instantiate a canvas)
  • Fixes to pydantic setup to try and stop unexpected coercions when the object type is permitted
  • Incorporated the new reference classes into code and tests
  • Fixed / cleaned up some old tests

@digitaldogsbody digitaldogsbody changed the title Range and thumbnail fix Range helpers, new skeleton, various fixes Oct 21, 2022
@glenrobson glenrobson merged commit 29ecff3 into main Nov 11, 2022
@glenrobson glenrobson deleted the range_and_thumbnail_fix branch November 11, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Range
2 participants