-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Range helpers, new skeleton, various fixes #84
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OK I've updated the schema so you should be able to update skeleton.py |
…n when not supplied
digitaldogsbody
requested review from
giacomomarchioro,
azaroth42,
glenrobson and
robcast
October 21, 2022 18:48
Skeleton py is updated - and various fixes have been made and also included in this PR
|
digitaldogsbody
changed the title
Range and thumbnail fix
Range helpers, new skeleton, various fixes
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows Ranges to be added by reference + adds make_range helper
Allows other item types to have thumbnails (NB: this will make some tests fail until IIIF/presentation-validator#151 is merged, and the
skeleton.py
file regenerated)closes #45