Skip to content

Commit

Permalink
Remove condition "js: true" from examples for deletion of snippets
Browse files Browse the repository at this point in the history
to make tests pass on Travis CI.
  • Loading branch information
KitaitiMakoto committed Jul 4, 2013
1 parent bb7be6a commit 4c20254
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion spec/features/snippets_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@
end
end

describe "DELETE /snippet/1", js: true do
describe "DELETE /snippet/1" do
context "when user is not logged in" do
it "should not show delete button" do
visit snippet_path(snippet.id)
Expand Down

2 comments on commit 4c20254

@KitaitiMakoto
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@banyan
I removed this condition to make tests pass on Travis CI.
But I don't know for what this exists.
Can we really remove it?

@banyan
Copy link
Member

@banyan banyan commented on 4c20254 Jul 4, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess this exists for confirm of js.

 15           = link_to snippet_path, class: 'btn btn-red', method: :delete, data: { confirm: "Are you sure to delete?" } do

But it's worked without js: true 😮
I feel https://travis-ci.org/iiirc/iiirc/jobs/8721903 this is just occationaly happened though.

Please sign in to comment.