FILLMTR (SEPT17) [Python] #195

abhigyank · 2017-10-03T10:48:16Z

Fixes #189

Pull Request Title is of form Problem Code (Contest Code) [Language].
This problem already had an entry in this repository.
- This solution is better than the one already in this repository.
This solution is prepared by me and not copied from anywhere else on the web.
I have added a copyright comment in my solution.
I have updated README.md file (in appropriate order).
I have read and followed Code Samples.
I understand that pull request will be closed if I failed to update it even once in a week.

aashutoshrathi · 2017-10-03T10:48:18Z

Hi! Thanks for contributing to this repository.
Make sure you have checked points in PR correctly.

abhigyank · 2017-10-03T10:55:22Z

Hey, I didn't understand what you posted. I haven't changed any of the files that are shown in the error.

Monal5031 · 2017-10-03T21:42:47Z

@abhigyank Don't get frightened over such long messages those are auto-generated gitmate issues, from what I can see you need to resolve conflicts and update your repo, thats it. 😉

abhigyank · 2017-10-04T05:08:37Z

@Monal5031 please review and merge.

aashutoshrathi · 2017-10-04T07:53:15Z

2017/SEPT/SEPT17/FILLMTR/FILLMTR.py

+            print "no"
+
+if __name__ == '__main__':
+    main()


Add a new line at the end.

@aashutoshrathi Done.

aashutoshrathi · 2017-10-04T07:54:54Z

@Monal5031 I request you not to delete, gitmate comments, as it will only raise coala issues.

Monal5031 · 2017-10-04T11:22:59Z

@aashutoshrathi I don't see travis in the check list, have you deactivated it?
Those gitmate messages are very much frightening and discouraging.
Also if you know gitmate raises issues on all the commits rather than the latest one, so each time a person updates a commit the same message of gitmate will be raised.

Monal5031 · 2017-10-04T11:30:54Z

@abhigyank Can make some changes and repush? Inorder to activate the travis build, so we can see what is causing the tests to fail.

abhigyank · 2017-10-04T11:40:13Z

@Monal5031 What changes can I make? Maybe you can check the Travis logs or see in the next PR.

Monal5031 · 2017-10-04T11:53:14Z

@abhigyank You can add spaces around binary operator, like a=b as a = b

abhigyank · 2017-10-04T14:59:52Z

@aashutoshrathi Maybe you should squash and merge now.

Monal5031 · 2017-10-05T21:49:24Z

@abhigyank Sorry for late reply but I can still see three issues in travis log for your PR.


|  26|    |-                    if(i[2]==1):

|    |  26|+                    if(i[2] == 1):

This one meaning you need to add space around binary opeator on line 26.
_________________________________________________________________

|  64|  64| 

|    |  65|+

|  65|  66| if __name__ == '__main__':

This one meaning you need to add a blank line before `if __name__ == '__main__':` on line 65.
__________________________________________________________________
|  64|  64| 

|  65|  65| if __name__ == '__main__':

|  66|  66|     main()

|  67|    |-    

This one meaning you have extra newline at end.

Monal5031 · 2017-10-10T22:07:49Z

ping @abhigyank Its been 5 days since this PR was last updated, please update it.

abhigyank · 2017-10-13T10:28:35Z

@Monal5031 Check now please.

aashutoshrathi · 2017-10-13T10:29:06Z

2017/SEPT/SEPT17/FILLMTR/FILLMTR.py

+        ans = 1
+        for i in range(n):
+            good.append('a')
+        good.append('a')


The code does not comply to PEP8.

Origin: PEP8Bear, Section: pep8.

The issue can be fixed by applying the following patch:

--- a/tmp/tmplt5sx928/2017/SEPT/SEPT17/FILLMTR/FILLMTR.py +++ b/tmp/tmplt5sx928/2017/SEPT/SEPT17/FILLMTR/FILLMTR.py @@ -62,7 +62,7 @@ else: print "no" - + if __name__ == '__main__': main()

aashutoshrathi · 2017-10-13T10:29:07Z

2017/SEPT/SEPT17/FILLMTR/FILLMTR.py

+        good.append('a')
+        for i in range(q):
+            a = map(int, raw_input().split())
+            queries.append(a)


The code does not comply to PEP8.

Origin: PEP8Bear, Section: pep8.

The issue can be fixed by applying the following patch:

--- a/tmp/tmplt5sx928/2017/SEPT/SEPT17/FILLMTR/FILLMTR.py +++ b/tmp/tmplt5sx928/2017/SEPT/SEPT17/FILLMTR/FILLMTR.py @@ -65,4 +65,3 @@ if __name__ == '__main__': main() -

abhigyank · 2017-10-14T11:42:11Z

@aashutoshrathi @Monal5031 All tests passed. Squash and merge PR.

abhigyank · 2017-10-18T20:10:54Z

Any reason why this hasn't been merged yet?

Monal5031 · 2017-10-30T09:03:17Z

@abhigyank Please resolve conflicts

FILLMTR (SEPT17) [Python]

9c52719

aashutoshrathi added process/pending_review size/XS labels Oct 3, 2017

Monal5031 self-assigned this Oct 3, 2017

Merge branch 'master' into master

ef45e79

aashutoshrathi reviewed Oct 4, 2017

View reviewed changes

Update FILLMTR.py

5be74d6

Monal5031 added the Hacktoberfest label Oct 4, 2017

Monal5031 added process/WIP and removed process/pending_review labels Oct 4, 2017

Add spaces around equal operator

64a4498

aashutoshrathi added process/pending_review and removed process/WIP labels Oct 4, 2017

Complied to PEP8

7c62c75

Monal5031 added process/WIP and removed process/pending_review labels Oct 5, 2017

Adhere to PEP8

8584f62

aashutoshrathi removed the process/WIP label Oct 13, 2017

aashutoshrathi added process/pending_review size/S and removed size/XS labels Oct 13, 2017

aashutoshrathi reviewed Oct 13, 2017

View reviewed changes

Compiled to PEP8

c3467b5

aashutoshrathi added status/test_passing and removed process/pending_review labels Oct 13, 2017

aashutoshrathi added the status/inactive label Oct 26, 2017

Monal5031 removed the Hacktoberfest label Oct 30, 2017

aashutoshrathi removed the status/inactive label Oct 30, 2017

aashutoshrathi added the status/inactive label Nov 16, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FILLMTR (SEPT17) [Python] #195

FILLMTR (SEPT17) [Python] #195

abhigyank commented Oct 3, 2017 •

edited

aashutoshrathi commented Oct 3, 2017

abhigyank commented Oct 3, 2017

Monal5031 commented Oct 3, 2017

abhigyank commented Oct 4, 2017

aashutoshrathi Oct 4, 2017

abhigyank Oct 4, 2017

aashutoshrathi commented Oct 4, 2017

Monal5031 commented Oct 4, 2017 •

edited

Monal5031 commented Oct 4, 2017

abhigyank commented Oct 4, 2017

Monal5031 commented Oct 4, 2017

abhigyank commented Oct 4, 2017

Monal5031 commented Oct 5, 2017 •

edited

Monal5031 commented Oct 10, 2017

abhigyank commented Oct 13, 2017

aashutoshrathi Oct 13, 2017

aashutoshrathi Oct 13, 2017

abhigyank commented Oct 14, 2017

abhigyank commented Oct 18, 2017

Monal5031 commented Oct 30, 2017

FILLMTR (SEPT17) [Python] #195

Are you sure you want to change the base?

FILLMTR (SEPT17) [Python] #195

Conversation

abhigyank commented Oct 3, 2017 • edited

aashutoshrathi commented Oct 3, 2017

abhigyank commented Oct 3, 2017

Monal5031 commented Oct 3, 2017

abhigyank commented Oct 4, 2017

aashutoshrathi Oct 4, 2017

Choose a reason for hiding this comment

abhigyank Oct 4, 2017

Choose a reason for hiding this comment

aashutoshrathi commented Oct 4, 2017

Monal5031 commented Oct 4, 2017 • edited

Monal5031 commented Oct 4, 2017

abhigyank commented Oct 4, 2017

Monal5031 commented Oct 4, 2017

abhigyank commented Oct 4, 2017

Monal5031 commented Oct 5, 2017 • edited

Monal5031 commented Oct 10, 2017

abhigyank commented Oct 13, 2017

aashutoshrathi Oct 13, 2017

Choose a reason for hiding this comment

aashutoshrathi Oct 13, 2017

Choose a reason for hiding this comment

abhigyank commented Oct 14, 2017

abhigyank commented Oct 18, 2017

Monal5031 commented Oct 30, 2017

abhigyank commented Oct 3, 2017 •

edited

Monal5031 commented Oct 4, 2017 •

edited

Monal5031 commented Oct 5, 2017 •

edited